Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222569
Change subject: Use core dimension widget times separator
......................................................................
Use core dimension widget times separator
For de-duplication, and because trailing whitespace is not allowed.
Bug: T104691
Change-Id: I2e65799daae7e57e6e638b3d6dcf968a6f4582c7
---
M extension.json
M modules/ve-mw/i18n/en.json
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/69/222569/1
diff --git a/extension.json b/extension.json
index a586623..429fe38 100644
--- a/extension.json
+++ b/extension.json
@@ -1094,7 +1094,6 @@
"visualeditor-dialog-media-content-filename",
"visualeditor-dialog-media-content-section",
"visualeditor-dialog-media-content-section-help",
- "visualeditor-dialog-media-dimensionseparator",
"visualeditor-dialog-media-goback",
"visualeditor-dialog-media-info-artist",
"visualeditor-dialog-media-info-audiofile",
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 30ad5ae..0bd5ea3 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -78,7 +78,6 @@
"visualeditor-dialog-media-content-filename": "File name",
"visualeditor-dialog-media-content-section": "Caption",
"visualeditor-dialog-media-content-section-help": "You can use this to
show a label that shows next to the item for all readers. This is often used to
explain why the item is relevant to the context in which it is shown. It should
be succinct and informative.",
- "visualeditor-dialog-media-dimensionseparator": " × ",
"visualeditor-dialog-media-goback": "Back",
"visualeditor-dialog-media-info-artist": "Uploaded by $1",
"visualeditor-dialog-media-info-audiofile": "Audio file",
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
index f30bdbc..cd50a11 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js
@@ -493,7 +493,9 @@
.append(
$( '<span>' ).text(
imageinfo.width +
- ve.msg(
'visualeditor-dialog-media-dimensionseparator' ) +
+ '\u00a0' +
+ ve.msg(
'visualeditor-dimensionswidget-times' ) +
+ '\u00a0' +
imageinfo.height +
ve.msg(
'visualeditor-dimensionswidget-px' )
),
--
To view, visit https://gerrit.wikimedia.org/r/222569
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e65799daae7e57e6e638b3d6dcf968a6f4582c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
