[MediaWiki-commits] [Gerrit] Fix Unhandled Exception ("RuntimeException") when trying to ... - change (phabricator/phabricator)

[Paladox (Code Review)]

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/222751

Change subject: Fix Unhandled Exception ("RuntimeException") when trying to 
view rSVN
......................................................................

Fix Unhandled Exception ("RuntimeException") when trying to view rSVN

Bug: T104732
Change-Id: Ia4f8b3115148fcd197482bc71c8b86a80f1ab704
---
M resources/celerity/map.php
M src/applications/diffusion/controller/DiffusionRepositoryController.php
M webroot/rsrc/css/application/base/standard-page-view.css
3 files changed, 11 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/phabricator/phabricator 
refs/changes/51/222751/1

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index ed0d2e2..de1cd36 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '75434d03',
+    'core.pkg.css' => '5630d89f',
     'core.pkg.js' => 'a590b451',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'cf384ffa',
@@ -37,7 +37,7 @@
     'rsrc/css/application/base/notification-menu.css' => 'f31c0bde',
     'rsrc/css/application/base/phabricator-application-launch-view.css' => 
'077e63cb',
     'rsrc/css/application/base/phui-theme.css' => '6b451f24',
-    'rsrc/css/application/base/standard-page-view.css' => 'def344d6',
+    'rsrc/css/application/base/standard-page-view.css' => '8920ef60',
     'rsrc/css/application/calendar/calendar-icon.css' => 'c69aa59f',
     'rsrc/css/application/chatlog/chatlog.css' => 'd295b020',
     'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
@@ -738,7 +738,7 @@
     'phabricator-side-menu-view-css' => 'bec2458e',
     'phabricator-slowvote-css' => '7c27f0f9',
     'phabricator-source-code-view-css' => '5e0178de',
-    'phabricator-standard-page-view' => 'def344d6',
+    'phabricator-standard-page-view' => '8920ef60',
     'phabricator-textareautils' => '5c93c52c',
     'phabricator-title' => 'df5e11d2',
     'phabricator-tooltip' => '1d298e3a',
diff --git 
a/src/applications/diffusion/controller/DiffusionRepositoryController.php 
b/src/applications/diffusion/controller/DiffusionRepositoryController.php
index 1d61836..3c45d81 100644
--- a/src/applications/diffusion/controller/DiffusionRepositoryController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryController.php
@@ -628,6 +628,7 @@
     $header->addActionLink($button);
     $browse_panel->setHeader($header);
 
+    $locate_panel = null;
     if ($repository->canUsePathTree()) {
       Javelin::initBehavior(
         'diffusion-locate-file',
diff --git a/webroot/rsrc/css/application/base/standard-page-view.css 
b/webroot/rsrc/css/application/base/standard-page-view.css
index 8b0279e..1ac13de 100644
--- a/webroot/rsrc/css/application/base/standard-page-view.css
+++ b/webroot/rsrc/css/application/base/standard-page-view.css
@@ -2,6 +2,13 @@
  * @provides phabricator-standard-page-view
  */
 
+/* wmf local hack to fix left-margin due to broken float:left in the header */
+.phabricator-standard-page-body:before {
+  display:block;
+  clear:both;
+  content:"";
+}
+
 .phabricator-anchor-view,
 .phabricator-anchor-navigation-marker {
   position: absolute;

-- 
To view, visit https://gerrit.wikimedia.org/r/222751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4f8b3115148fcd197482bc71c8b86a80f1ab704
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/phabricator
Gerrit-Branch: redesign-2015-wmf
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits