BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222870
Change subject: Hygiene: Remove useless parent layout in featured page widget
......................................................................
Hygiene: Remove useless parent layout in featured page widget
Lint warning:
../../res/layout/widget_featured_page.xml:25: This LinearLayout layout or its
FrameLayout parent is useless; transfer the background attribute to the other
view
Change-Id: Idc1f5c0864b1340b11735d059d21dfc35923379f
---
M wikipedia/res/layout/widget_featured_page.xml
1 file changed, 5 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/70/222870/1
diff --git a/wikipedia/res/layout/widget_featured_page.xml
b/wikipedia/res/layout/widget_featured_page.xml
index 10952ce..1d2ad37 100644
--- a/wikipedia/res/layout/widget_featured_page.xml
+++ b/wikipedia/res/layout/widget_featured_page.xml
@@ -16,16 +16,13 @@
android:src="@drawable/about_logo"
android:contentDescription="@null"
android:layout_gravity="center_vertical"/>
- <FrameLayout
- android:layout_width="match_parent"
- android:layout_height="match_parent"
- android:paddingLeft="16dp"
- android:paddingRight="16dp"
- android:background="@drawable/widget_shape_inner">
<LinearLayout
android:layout_width="match_parent"
- android:layout_height="wrap_content"
- android:layout_gravity="center_vertical"
+ android:layout_height="match_parent"
+ android:paddingLeft="16dp"
+ android:paddingRight="16dp"
+ android:gravity="center_vertical"
+ android:background="@drawable/widget_shape_inner"
android:orientation="vertical">
<TextView
android:layout_width="match_parent"
@@ -48,5 +45,4 @@
tools:text="Sample content"
/>
</LinearLayout>
- </FrameLayout>
</LinearLayout>
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/222870
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc1f5c0864b1340b11735d059d21dfc35923379f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
