[MediaWiki-commits] [Gerrit] Add pages with Cite errors to a tracking category - change (mediawiki...Cite)

[Amire80 (Code Review)]

Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/222897

Change subject: Add pages with Cite errors to a tracking category
......................................................................

Add pages with Cite errors to a tracking category

Bug: T104792
Change-Id: I6f8b12788a20480bd8880332238d545ee70a8ef9
---
M Cite_body.php
M extension.json
M i18n/en.json
3 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cite 
refs/changes/97/222897/1

diff --git a/Cite_body.php b/Cite_body.php
index e800d94..abfd0ee 100644
--- a/Cite_body.php
+++ b/Cite_body.php
@@ -252,6 +252,8 @@
                        # be equivalent <ref ... />, for compatability with 
#tag.
                        if ( $key == false ) {
                                $this->mRefCallStack[] = false;
+
+
                                return $this->error( 'cite_error_ref_no_input' 
);
                        } else {
                                $str = null;
@@ -1144,6 +1146,8 @@
                        ->inContentLanguage()
                        ->plain();
 
+               $this->mParser->addTrackingCategory( 
'cite-tracking-category-cite-error' );
+
                $ret = '<strong class="error mw-ext-cite-error">' . $msg . 
'</strong>';
 
                if ( $parse == 'parse' ) {
diff --git a/extension.json b/extension.json
index 6b19973..858a561 100644
--- a/extension.json
+++ b/extension.json
@@ -73,5 +73,8 @@
        "ParserTestFiles": [
                "citeParserTests.txt"
        ],
+       "TrackingCategories": [
+               "cite-tracking-category-cite-error"
+       ],
        "manifest_version": 1
 }
diff --git a/i18n/en.json b/i18n/en.json
index 5c5ad60..d6a4da1 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -32,6 +32,8 @@
        "cite_error_references_missing_key": "<code>&lt;ref&gt;</code> tag with 
name \"$1\" defined in <code>&lt;references&gt;</code> is not used in prior 
text.",
        "cite_error_references_no_key": "<code>&lt;ref&gt;</code> tag defined 
in <code>&lt;references&gt;</code> has no name attribute.",
        "cite_error_empty_references_define": "<code>&lt;ref&gt;</code> tag 
defined in <code>&lt;references&gt;</code> with name \"$1\" has no content.",
+       "cite-tracking-category-cite-error": "Pages with reference errors",
+       "cite-tracking-category-cite-error-desc": "Pages in this category have 
errors in the usage of references tags.",
        "cite_reference_link_key_with_num": "$1_$2",
        "cite_reference_link_prefix": "cite_ref-",
        "cite_reference_link_suffix": "",

-- 
To view, visit https://gerrit.wikimedia.org/r/222897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f8b12788a20480bd8880332238d545ee70a8ef9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits