Krinkle has submitted this change and it was merged. Change subject: (bug 42220) Added support for edit notices, which appear on the toolbar ......................................................................
(bug 42220) Added support for edit notices, which appear on the toolbar ApiVisualEditor * Including notices in response to parse actions ve.init.mw.ViewPageTarget * Added styles for editNoticeButton and editNotices ve.init.mw.ViewPageTarget * Added toolbarEditNoticeButton and toolbarEditNotices * Combined toolbarEditNoticeButton and toolbarSaveButton setup * Moved toolbar buttons setup to onLoad (it could vary per-parse now) * Added tearDownToolbarButtons which fires on deactivate * Renamed some instances of teardown to tearDown * Added click handler for toolbarEditNoticeButton * Added toolbarEditNotices setup method, called on load * Made notices fade in and out, in by default on load if any * Made notices hide when save dialog is opened ve.init.mw.Target * Added storing of notices on parse icons, alert, ve.ui-Icons * Added alert icon VisualEditor.i18n, VisualEditor * Added notices button message Change-Id: I581bf5a005a9c18422f952d71064d17d0ba9b540 --- M ApiVisualEditor.php M VisualEditor.i18n.php M VisualEditor.php M modules/ve/init/mw/styles/ve.init.mw.ViewPageTarget.css M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js M modules/ve/init/mw/ve.init.mw.Target.js M modules/ve/ui/styles/images/icons.ai A modules/ve/ui/styles/images/icons/alert.png A modules/ve/ui/styles/images/icons/alert.svg M modules/ve/ui/styles/ve.ui.Icons-raster.css M modules/ve/ui/styles/ve.ui.Icons-vector.css 11 files changed, 717 insertions(+), 7,907 deletions(-) Approvals: Krinkle: Looks good to me, approved Siebrand: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/36318 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I581bf5a005a9c18422f952d71064d17d0ba9b540 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <tpars...@wikimedia.org> Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
