Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224072
Change subject: Include references in statementview.isInitialValue()
......................................................................
Include references in statementview.isInitialValue()
This is currently not relevant in production because the statementview is
not used to edit references along with the statement and qualifiers, but
this will change in later patches.
This is split from I9444ae5 to make it easier to review.
Bug: T87759
Change-Id: If4534806ab7785b1e421f7b0310db0f4765f4b43
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/72/224072/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 30dfca0..cb8fc3e 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -494,6 +494,8 @@
* @return {boolean}
*/
isInitialValue: function() {
+ var i;
+
if( this.options.value ) {
if( !this._rankSelector.isInitialValue() ) {
return false;
@@ -504,13 +506,27 @@
// Generate a SnakList object featuring all current
qualifier snaks to be able to
// compare it to the SnakList object the claimview has
been initialized with:
- for( var i = 0; i < snaklistviews.length; i++ ) {
+ for( i = 0; i < snaklistviews.length; i++ ) {
qualifiers.merge( snaklistviews[i].value() );
}
if( !qualifiers.equals(
this.options.value.getClaim().getQualifiers() ) ) {
return false;
}
+
+ var referenceviews = this._referencesListview ?
this._referencesListview.value() : [],
+ references = new wb.datamodel.ReferenceList();
+
+ for( i = 0; i < referenceviews.length; i++ ) {
+ var reference = referenceviews[i].value();
+ if( reference ) {
+ references.addItem( reference );
+ }
+ }
+
+ if( !references.equals(
this.options.value.getReferences() ) ) {
+ return false;
+ }
}
return this.$mainSnak.data( 'snakview' ).isInitialValue();
--
To view, visit https://gerrit.wikimedia.org/r/224072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4534806ab7785b1e421f7b0310db0f4765f4b43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
