Anomie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224073
Change subject: ApiFeedWatchlist: Handle revdel
......................................................................
ApiFeedWatchlist: Handle revdel
We might get back rows with no title (log entries with deleted action)
or no user (anything with deleted user). Don't raise warnings for those.
Bug: T105367
Change-Id: I64b4fba478b3e1e86854843965b2ea2b5c1d7933
---
M includes/api/ApiFeedWatchlist.php
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/73/224073/1
diff --git a/includes/api/ApiFeedWatchlist.php
b/includes/api/ApiFeedWatchlist.php
index 853b138..0ddb3c3 100644
--- a/includes/api/ApiFeedWatchlist.php
+++ b/includes/api/ApiFeedWatchlist.php
@@ -169,6 +169,11 @@
* @return FeedItem
*/
private function createFeedItem( $info ) {
+ if ( !isset( $info['title'] ) ) {
+ // Probably a revdeled log entry, skip it.
+ return null;
+ }
+
$titleStr = $info['title'];
$title = Title::newFromText( $titleStr );
$curidParam = array();
@@ -205,9 +210,14 @@
}
$timestamp = $info['timestamp'];
- $user = $info['user'];
- $completeText = "$comment ($user)";
+ if ( isset( $info['user'] ) ) {
+ $user = $info['user'];
+ $completeText = "$comment ($user)";
+ } else {
+ $user = '';
+ $completeText = (string)$comment;
+ }
return new FeedItem( $titleStr, $completeText, $titleUrl,
$timestamp, $user );
}
--
To view, visit https://gerrit.wikimedia.org/r/224073
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64b4fba478b3e1e86854843965b2ea2b5c1d7933
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
