Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224225
Change subject: Use correct variable in UserCache::doQuery
......................................................................
Use correct variable in UserCache::doQuery
The variable $row is set to the last user of the first loop. Using the
$name which is set in the foreach correctly.
This now adds all userpages to the LinkBatch and that avoids some extra
queries on at least Special:ListFiles
Change-Id: Ied378b1596ec9d38eda41ce5ee413203c65eb21b
---
M includes/cache/UserCache.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/25/224225/1
diff --git a/includes/cache/UserCache.php b/includes/cache/UserCache.php
index 2a3aac2..51bf385 100644
--- a/includes/cache/UserCache.php
+++ b/includes/cache/UserCache.php
@@ -123,11 +123,11 @@
$lb = new LinkBatch();
foreach ( $usersToCheck as $userId => $name ) {
if ( $this->queryNeeded( $userId, 'userpage', $options
) ) {
- $lb->add( NS_USER, $row->user_name );
+ $lb->add( NS_USER, $name );
$this->typesCached[$userId]['userpage'] = 1;
}
if ( $this->queryNeeded( $userId, 'usertalk', $options
) ) {
- $lb->add( NS_USER_TALK, $row->user_name );
+ $lb->add( NS_USER_TALK, $name );
$this->typesCached[$userId]['usertalk'] = 1;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/224225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied378b1596ec9d38eda41ce5ee413203c65eb21b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
