jenkins-bot has submitted this change and it was merged.
Change subject: Add space between input fields and buttons
......................................................................
Add space between input fields and buttons
It looks strange, if the button is directly after the input field
without any space.
Change-Id: I6435df75253080b68164415b354248ace2bbaede
---
M InputBox.classes.php
M resources/ext.inputBox.styles.css
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/InputBox.classes.php b/InputBox.classes.php
index 4cdcbe9..3cf0507 100644
--- a/InputBox.classes.php
+++ b/InputBox.classes.php
@@ -123,7 +123,7 @@
);
$htmlOut .= Xml::element( 'input',
array(
- 'class' => 'searchboxInput mw-ui-input
mw-ui-input-inline',
+ 'class' => 'mw-inputbox-input searchboxInput
mw-ui-input mw-ui-input-inline',
'name' => 'search',
'type' => $this->mHidden ? 'hidden' : 'text',
'value' => $this->mDefaultText,
@@ -431,7 +431,8 @@
array(
'type' => $this->mHidden ? 'hidden' : 'text',
'name' => 'title',
- 'class' => 'mw-ui-input mw-ui-input-inline
createboxInput',
+ 'class' => ( strtolower( $this->mBR ) === '<br
/>' ? 'mw-inputbox-input ' : '' ) .
+ 'mw-ui-input mw-ui-input-inline
createboxInput',
'value' => $this->mDefaultText,
'placeholder' => $this->mPlaceholderText,
'size' => $this->mWidth,
@@ -505,7 +506,7 @@
array(
'type' => $this->mHidden ? 'hidden' : 'text',
'name' => 'wpNewTitle',
- 'class' => 'mw-moveboxInput mw-ui-input
mw-ui-input-inline',
+ 'class' => 'mw-inputbox-input mw-moveboxInput
mw-ui-input mw-ui-input-inline',
'value' => $this->mDefaultText,
'placeholder' => $this->mPlaceholderText,
'size' => $this->mWidth,
@@ -587,7 +588,7 @@
array(
'type' => $this->mHidden ? 'hidden' : 'text',
'name' => 'preloadtitle',
- 'class' => 'commentboxInput mw-ui-input
mw-ui-input-inline',
+ 'class' => 'mw-inputbox-input commentboxInput
mw-ui-input mw-ui-input-inline',
'value' => $this->mDefaultText,
'placeholder' => $this->mPlaceholderText,
'size' => $this->mWidth,
diff --git a/resources/ext.inputBox.styles.css
b/resources/ext.inputBox.styles.css
index 9a996a4..d2d1e13 100644
--- a/resources/ext.inputBox.styles.css
+++ b/resources/ext.inputBox.styles.css
@@ -13,3 +13,7 @@
display: inline-table !important;
white-space: nowrap;
}
+
+.mw-inputbox-input {
+ margin-bottom: 0.5em;
+}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/206613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6435df75253080b68164415b354248ace2bbaede
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/InputBox
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
