XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/224310

Change subject: [FIX] page: Return timestamp string
......................................................................

[FIX] page: Return timestamp string

Several methods (BasePage.getCreator(), FilePage.getLatestUploader() and
FilePage.getFirstUploader()) use the direct result from the API and not a
Timestamp instance.

Change-Id: I82c2984ec736529acbe3aa8ac9dde6aadb91fcdd
---
M pywikibot/page.py
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/10/224310/1

diff --git a/pywikibot/page.py b/pywikibot/page.py
index adac029..9e97e9c 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -1578,7 +1578,7 @@
         @rtype: tuple(username, Timestamp)
         """
         result = self.oldest_revision
-        return result.user, result.timestamp
+        return result.user, result.timestamp.isoformat()
 
     @deprecated('contributors() or revisions()')
     @deprecated_args(limit="total")
@@ -2229,7 +2229,8 @@
         For compatibility with compat only.
 
         """
-        return [self.oldest_file_info.user, self.oldest_file_info.timestamp]
+        return [self.oldest_file_info.user,
+                self.oldest_file_info.timestamp.isoformat()]
 
     @deprecated("FilePage.latest_file_info.user")
     def getLatestUploader(self):
@@ -2238,7 +2239,8 @@
         For compatibility with compat only.
 
         """
-        return [self.latest_file_info.user, self.latest_file_info.timestamp]
+        return [self.latest_file_info.user,
+                self.latest_file_info.timestamp.isoformat()]
 
     @deprecated('FilePage.get_file_history()')
     def getFileVersionHistory(self):

-- 
To view, visit https://gerrit.wikimedia.org/r/224310
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82c2984ec736529acbe3aa8ac9dde6aadb91fcdd
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <commodorefabia...@gmx.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to