Hashar has submitted this change and it was merged. Change subject: linter did not work properly on extensions ......................................................................
linter did not work properly on extensions The 'php-lint' ant target lookup for change in the $sourcedir which default to being the workspace. Since extensions are checked out in a subdirectory, we ended up finding files from the general working copy /var/lib/jenkins which is incorrect. By overriding the sourcedir to the correct path, we get the expected value. Maybe sourcedir should be corrected in the property file, but that workaround is good enough for now. Change-Id: I5f443cfee2eff89804b5baa5d542b0d6f4c5ffa8 --- M mediawiki-extensions.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36732 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f443cfee2eff89804b5baa5d542b0d6f4c5ffa8 Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Hashar <has...@free.fr> Gerrit-Reviewer: Hashar <has...@free.fr> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
