jenkins-bot has submitted this change and it was merged.
Change subject: Fix blurry banners when no support for srcset
......................................................................
Fix blurry banners when no support for srcset
Set src attribute of banner image to url of largest in order to load best banner
when browser has no support for srcset.
Bug: T105203
Change-Id: I0b659b30b89171a91c70b0e243accf7f0046d1b6
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
Nicolas Raoul: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 29e57c7..4ce610a 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -195,7 +195,8 @@
}
// create full src set from individual urls, separated
by comma
$srcset = implode( ',', $srcset );
- $bannerurl = $urls[0];
+ // use largest image url as src attribute
+ $bannerurl = $urls[count( $urls ) - 1];
$bannerfile = str_replace( "$1", "File:$bannername",
$wgArticlePath );
$templateParser = new TemplateParser( __DIR__ .
'/../templates' );
$options['bannerfile'] = $bannerfile;
--
To view, visit https://gerrit.wikimedia.org/r/223746
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b659b30b89171a91c70b0e243accf7f0046d1b6
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Nicolas Raoul <nicolas.ra...@gmail.com>
Gerrit-Reviewer: Sumit <asthana.sumi...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
