Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/224798
Change subject: Tweak appearance of tab list. ...................................................................... Tweak appearance of tab list. - Increase the height of tab list items. - Update the "add tab" icon. (flattened "plus" sign, instead of layered) Bug: T104263 Change-Id: I23981b8032fcf3720bf3b9f9102c1da8c31658d5 --- M icon-svgs/24/ic_add_tab.noflip.svg M wikipedia/res/drawable-hdpi/ic_add_tab.png M wikipedia/res/drawable-ldpi/ic_add_tab.png M wikipedia/res/drawable-mdpi/ic_add_tab.png M wikipedia/res/drawable-xhdpi/ic_add_tab.png M wikipedia/res/drawable-xxhdpi/ic_add_tab.png M wikipedia/res/layout/item_tab_entry.xml M wikipedia/res/values/dimens.xml 8 files changed, 10 insertions(+), 66 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/98/224798/1 diff --git a/icon-svgs/24/ic_add_tab.noflip.svg b/icon-svgs/24/ic_add_tab.noflip.svg index 0e7f37e..5f36396 100644 --- a/icon-svgs/24/ic_add_tab.noflip.svg +++ b/icon-svgs/24/ic_add_tab.noflip.svg @@ -1,60 +1,4 @@ -<?xml version="1.0" encoding="UTF-8" standalone="no"?> -<svg - xmlns:dc="http://purl.org/dc/elements/1.1/"; - xmlns:cc="http://creativecommons.org/ns#"; - xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"; - xmlns:svg="http://www.w3.org/2000/svg"; - xmlns="http://www.w3.org/2000/svg"; - xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"; - xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"; - width="24" - height="24" - viewBox="0 0 24 24" - id="svg2" - version="1.1" - inkscape:version="0.91 r13725" - sodipodi:docname="ic_add_tab.noflip.svg"> - <metadata - id="metadata12"> - <rdf:RDF> - <cc:Work - rdf:about=""> - <dc:format>image/svg+xml</dc:format> - <dc:type - rdf:resource="http://purl.org/dc/dcmitype/StillImage"; /> - </cc:Work> - </rdf:RDF> - </metadata> - <defs - id="defs10" /> - <sodipodi:namedview - pagecolor="#ffffff" - bordercolor="#666666" - borderopacity="1" - objecttolerance="10" - gridtolerance="10" - guidetolerance="10" - inkscape:pageopacity="0" - inkscape:pageshadow="2" - inkscape:window-width="1156" - inkscape:window-height="725" - id="namedview8" - showgrid="false" - inkscape:zoom="27.812867" - inkscape:cx="6.8946906" - inkscape:cy="10.24447" - inkscape:window-x="0" - inkscape:window-y="0" - inkscape:window-maximized="0" - inkscape:current-layer="svg2" /> - <path - d="M0 0h24v24h-24z" - fill="none" - id="path4" /> - <path - d="M 4,6 2,6 2,20 c 0,1.1 0.9,2 2,2 l 14,0 0,-2 -14,0 z M 20,2 8,2 C 6.9,2 6,2.9 6,4 l 0,12 c 0,1.1 0.9,2 2,2 l 12,0 c 1.1,0 2,-0.9 2,-2 L 22,4 C 22,2.9 21.1,2 20,2 Z m -1,9 -4,0 0,4 -2,0 0,-4 -4,0 0,-2 4,0 0,-4 2,0 0,4 4,0 z" - id="path6" - style="fill:#ffffff" - inkscape:connector-curvature="0" - sodipodi:nodetypes="ccssccccsssssssssccccccccccccc" /> -</svg> +<svg fill="#FFFFFF" height="24" viewBox="0 0 24 24" width="24" xmlns="http://www.w3.org/2000/svg";> + <path d="M19 3H5c-1.11 0-2 .9-2 2v14c0 1.1.89 2 2 2h14c1.1 0 2-.9 2-2V5c0-1.1-.9-2-2-2zm-2 10h-4v4h-2v-4H7v-2h4V7h2v4h4v2z"/> + <path d="M0 0h24v24H0z" fill="none"/> +</svg> \ No newline at end of file diff --git a/wikipedia/res/drawable-hdpi/ic_add_tab.png b/wikipedia/res/drawable-hdpi/ic_add_tab.png index 3950fda..0a1a3d8 100644 --- a/wikipedia/res/drawable-hdpi/ic_add_tab.png +++ b/wikipedia/res/drawable-hdpi/ic_add_tab.png Binary files differ diff --git a/wikipedia/res/drawable-ldpi/ic_add_tab.png b/wikipedia/res/drawable-ldpi/ic_add_tab.png index c681198..f9dd676 100644 --- a/wikipedia/res/drawable-ldpi/ic_add_tab.png +++ b/wikipedia/res/drawable-ldpi/ic_add_tab.png Binary files differ diff --git a/wikipedia/res/drawable-mdpi/ic_add_tab.png b/wikipedia/res/drawable-mdpi/ic_add_tab.png index db34796..e182390 100644 --- a/wikipedia/res/drawable-mdpi/ic_add_tab.png +++ b/wikipedia/res/drawable-mdpi/ic_add_tab.png Binary files differ diff --git a/wikipedia/res/drawable-xhdpi/ic_add_tab.png b/wikipedia/res/drawable-xhdpi/ic_add_tab.png index f44b86d..94eb62b 100644 --- a/wikipedia/res/drawable-xhdpi/ic_add_tab.png +++ b/wikipedia/res/drawable-xhdpi/ic_add_tab.png Binary files differ diff --git a/wikipedia/res/drawable-xxhdpi/ic_add_tab.png b/wikipedia/res/drawable-xxhdpi/ic_add_tab.png index 77a2d35..f66af4b 100644 --- a/wikipedia/res/drawable-xxhdpi/ic_add_tab.png +++ b/wikipedia/res/drawable-xxhdpi/ic_add_tab.png Binary files differ diff --git a/wikipedia/res/layout/item_tab_entry.xml b/wikipedia/res/layout/item_tab_entry.xml index 0d6c5f0..c172352 100644 --- a/wikipedia/res/layout/item_tab_entry.xml +++ b/wikipedia/res/layout/item_tab_entry.xml @@ -14,9 +14,9 @@ > <ImageView android:id="@+id/tab_item_thumbnail" - android:layout_height="32dp" - android:layout_width="32dp" - android:layout_margin="8dp" + android:layout_height="@dimen/tabImageSize" + android:layout_width="@dimen/tabImageSize" + android:layout_margin="4dp" android:layout_gravity="center_vertical" android:scaleType="centerCrop" android:src="@drawable/ic_pageimage_placeholder" @@ -40,8 +40,8 @@ android:id="@+id/tab_item_close" android:layout_height="@dimen/tabImageSize" android:layout_width="@dimen/tabImageSize" - android:layout_margin="8dp" - android:padding="4dp" + android:layout_margin="4dp" + android:padding="12dp" android:layout_gravity="center_vertical" android:src="@drawable/ic_close_gray" android:contentDescription="@string/button_close_tab" diff --git a/wikipedia/res/values/dimens.xml b/wikipedia/res/values/dimens.xml index 94b68b1..f204695 100644 --- a/wikipedia/res/values/dimens.xml +++ b/wikipedia/res/values/dimens.xml @@ -15,7 +15,7 @@ <dimen name="defaultListItemSize">72dp</dimen> <!-- Default height of tab item images, which governs the size of tabs themselves --> - <dimen name="tabImageSize">32dp</dimen> + <dimen name="tabImageSize">48dp</dimen> <!-- Default width of the lead image to be downloaded --> <dimen name="leadImageWidth">640dp</dimen> -- To view, visit https://gerrit.wikimedia.org/r/224798 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I23981b8032fcf3720bf3b9f9102c1da8c31658d5 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
