jenkins-bot has submitted this change and it was merged.
Change subject: Fix issue where lead image becomes white box in dark mode.
......................................................................
Fix issue where lead image becomes white box in dark mode.
Bug: T104103
Change-Id: I653b2a0277833b24edf6c02583e21c3ffdd83bf0
---
M wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
BearND: Looks good to me, approved
Niedzielski: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
b/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
index 6bd3143..658feb6 100755
---
a/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
+++
b/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java
@@ -448,6 +448,8 @@
+ DISABLED_OFFSET_DP;
imageContainer.setLayoutParams(new
LinearLayout.LayoutParams(LinearLayout.LayoutParams.MATCH_PARENT,
(int) ((titleContainerHeight) * displayDensity)));
+ // reset the background on the lead image, in case we previously
set it to white.
+ image1.setBackgroundColor(Color.TRANSPARENT);
// hide the lead image
image1.setVisibility(View.GONE);
image1.setImageDrawable(null);
--
To view, visit https://gerrit.wikimedia.org/r/224800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I653b2a0277833b24edf6c02583e21c3ffdd83bf0
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
