Ladsgroup has uploaded a new change for review.
https://gerrit.wikimedia.org/r/224952
Change subject: Disable caching in SpecialUnconnectedPages.
......................................................................
Disable caching in SpecialUnconnectedPages.
After lots of talk with Daniel Kinzler and Brad Jorsh
we decided to disable caching for several reasons:
- It can't store page_num_iwlinks
- It is not expensive now
Change-Id: I3cc8a5c60eacf09e5c9598f0e92986ae46acc735
---
M client/includes/specials/SpecialUnconnectedPages.php
1 file changed, 10 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/52/224952/1
diff --git a/client/includes/specials/SpecialUnconnectedPages.php
b/client/includes/specials/SpecialUnconnectedPages.php
index 95c5db6..d230d1a 100644
--- a/client/includes/specials/SpecialUnconnectedPages.php
+++ b/client/includes/specials/SpecialUnconnectedPages.php
@@ -52,6 +52,16 @@
}
/**
+ * @see QueryPage::isCacheable
+ *
+ * @return bool Always false because we can not have caching since we
will store additional information.
+ */
+ public function isCacheable() {
+ return false;
+ }
+
+
+ /**
* @since 0.4
*
* @param NamespaceChecker $namespaceChecker
@@ -153,22 +163,6 @@
}
return parent::reallyDoQuery( $limit, $offset );
- }
-
- /**
- * @see QueryPage::fetchFromCache
- *
- * @param int|bool $limit
- * @param int|bool $offset
- *
- * @return ResultWrapper
- */
- function fetchFromCache( $limit, $offset = false ) {
- if ( is_int( $offset ) && $offset > self::MAX_OFFSET ) {
- return new FakeResultWrapper( array() );
- }
-
- return parent::fetchFromCache( $limit, $offset );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/224952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cc8a5c60eacf09e5c9598f0e92986ae46acc735
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
