jenkins-bot has submitted this change and it was merged.
Change subject: QA: Fix menu browser test
......................................................................
QA: Fix menu browser test
Fixes in phantomjs but not Chrome
Bug: T105878
Change-Id: Ia7dd66f5035166b200e7708b6a5a58243e2dffb9
---
M tests/browser/features/step_definitions/common_steps.rb
M tests/browser/features/step_definitions/menu_steps.rb
M tests/browser/features/support/pages/article_page.rb
3 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Robmoen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index ec53a06..65846bb 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -28,6 +28,8 @@
page.goto
# Disable the onboarding tutorials
page.browser.execute_script("localStorage.setItem('gather-has-dismissed-tutorial','true');")
+
page.browser.execute_script("localStorage.setItem('gather-has-dismissed-mainmenu','true');")
+
# A domain is explicitly given to avoid a bug in earlier versions of Chrome
page.browser.cookies.add 'optin', 'beta', domain:
URI.parse(page.page_url_value).host
page.refresh
diff --git a/tests/browser/features/step_definitions/menu_steps.rb
b/tests/browser/features/step_definitions/menu_steps.rb
index d33e904..e48d0e1 100644
--- a/tests/browser/features/step_definitions/menu_steps.rb
+++ b/tests/browser/features/step_definitions/menu_steps.rb
@@ -1,5 +1,5 @@
When(/^I click on the main navigation button$/) do
- on(ArticlePage).mainmenu_button_element.click
+ on(ArticlePage).mainmenu_button_element.when_present.click
end
Then(/^I should see a link to "(.*?)" in the main navigation menu$/) do |text|
diff --git a/tests/browser/features/support/pages/article_page.rb
b/tests/browser/features/support/pages/article_page.rb
index 4f6dc8c..81c28ba 100644
--- a/tests/browser/features/support/pages/article_page.rb
+++ b/tests/browser/features/support/pages/article_page.rb
@@ -3,7 +3,7 @@
page_url "<%= URI.encode(params[:article_name]) %><%= params[:hash] %>"
# UI elements
- a(:mainmenu_button, id: 'mw-mf-main-menu-button')
+ a(:mainmenu_button, css: '.main-menu-button', index: 0)
# left nav
nav(:navigation, css: 'nav')
--
To view, visit https://gerrit.wikimedia.org/r/224796
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7dd66f5035166b200e7708b6a5a58243e2dffb9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: BarryTheBrowserTestBot <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
