Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/224999

Change subject: Don't show groups on Special:ListGroupRights if they have no 
actual enabled rights
......................................................................

Don't show groups on Special:ListGroupRights if they have no actual enabled 
rights

Change-Id: I9b80679ec4f9980619969f7af78bcf6a646fd3d4
---
M includes/specials/SpecialListgrouprights.php
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/99/224999/1

diff --git a/includes/specials/SpecialListgrouprights.php 
b/includes/specials/SpecialListgrouprights.php
index 828a93b..5950595 100644
--- a/includes/specials/SpecialListgrouprights.php
+++ b/includes/specials/SpecialListgrouprights.php
@@ -56,7 +56,17 @@
 
                $config = $this->getConfig();
                $groupPermissions = $config->get( 'GroupPermissions' );
+               foreach ( $groupPermissions as $group => $rights ) {
+                       if ( count( array_filter( $rights ) ) === 0 ) {
+                               unset( $groupPermissions[$group] );
+                       }
+               }
                $revokePermissions = $config->get( 'RevokePermissions' );
+               foreach ( $revokePermissions as $group => $rights ) {
+                       if ( count( array_filter( $rights ) ) === 0 ) {
+                               unset( $revokePermissions[$group] );
+                       }
+               }
                $addGroups = $config->get( 'AddGroups' );
                $removeGroups = $config->get( 'RemoveGroups' );
                $groupsAddToSelf = $config->get( 'GroupsAddToSelf' );

-- 
To view, visit https://gerrit.wikimedia.org/r/224999
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b80679ec4f9980619969f7af78bcf6a646fd3d4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to