Filippo Giunchedi has submitted this change and it was merged.
Change subject: eliminate redundant threshold alerts
......................................................................
eliminate redundant threshold alerts
The thread pool thresholds are applied to all internal queues, including
the CompactionExecutor, which is also captured by the pending compactions
metric. As a result, we receive notifications in pairs, one for the
pending compactions threshold, and one generated by the CompactionExecutor
thread pool queue.
This changeset excludes CompactionExecutor from the thread pool metrics
threshold.
Change-Id: Ib6cc1451eb62ee46e46b9d964a0964f4de777967
---
M manifests/role/restbase.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Filippo Giunchedi: Verified; Looks good to me, approved
GWicke: Looks good to me, but someone else must approve
diff --git a/manifests/role/restbase.pp b/manifests/role/restbase.pp
index 4e9b995..d04d036 100644
--- a/manifests/role/restbase.pp
+++ b/manifests/role/restbase.pp
@@ -104,7 +104,7 @@
monitoring::graphite_threshold {
'restbase_cassandra_highest_pending_internal':
description => 'RESTBase Cassandra highest pending internal thread
pool tasks
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-thread-pools',
- metric =>
'highestMax(cassandra.restbase10*.org.apache.cassandra.metrics.ThreadPools.internal.*.PendingTasks.value,
1)',
+ metric =>
'highestMax(exclude(cassandra.restbase10*.org.apache.cassandra.metrics.ThreadPools.internal.*.PendingTasks.value,
"CompactionExecutor"), 1)',
from => '10min',
warning => '500',
critical => '1000',
--
To view, visit https://gerrit.wikimedia.org/r/225184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6cc1451eb62ee46e46b9d964a0964f4de777967
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Eevans <eev...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
