jenkins-bot has submitted this change and it was merged.
Change subject: Fixed reference issue in AkismetKlik::Filter() signature
......................................................................
Fixed reference issue in AkismetKlik::Filter() signature
The AkismetKlik::Filter() $title parameter were set by reference, but:
- this method doesn't edit the parameter value
- this method is called with $spamObj->filter(
$editPage->getArticle()->getTitle(), ...)
Bug: T105480
Change-Id: Iec1d894285f3a462878dbd8250f875a769bf2dbc
---
M AkismetKlik.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/AkismetKlik.php b/AkismetKlik.php
index d938b24..5dcfce0 100644
--- a/AkismetKlik.php
+++ b/AkismetKlik.php
@@ -82,7 +82,7 @@
* @return bool True if the edit should not be allowed, false otherwise
* If the return value is true, an error will have been sent to $wgOut
*/
- function filter( &$title, $text, $section, $editPage ) {
+ function filter( $title, $text, $section, $editPage ) {
global $wgParser, $wgUser, $wgAKSiteUrl, $wgAKkey, $IP;
if ( strlen( $wgAKkey ) == 0 ) {
--
To view, visit https://gerrit.wikimedia.org/r/224065
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec1d894285f3a462878dbd8250f875a769bf2dbc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AkismetKlik
Gerrit-Branch: master
Gerrit-Owner: Dereckson <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Carlb <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
