Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/226618
Change subject: Do not retry UploadMediafileJob jobs with bad parameters
......................................................................
Do not retry UploadMediafileJob jobs with bad parameters
* Not sure why these can even be sumbitted, but any case
there is no use in retrying them
Change-Id: Ib6eceb698f3856da97869a52826ccad94ad08973
---
M includes/Jobs/UploadMediafileJob.php
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GWToolset
refs/changes/18/226618/1
diff --git a/includes/Jobs/UploadMediafileJob.php
b/includes/Jobs/UploadMediafileJob.php
old mode 100644
new mode 100755
index ce4cdd5..5e90d3d
--- a/includes/Jobs/UploadMediafileJob.php
+++ b/includes/Jobs/UploadMediafileJob.php
@@ -29,6 +29,8 @@
* @var {User}
*/
protected $User;
+ /** @var bool Allow retries */
+ protected $allowRetry = true;
/**
* @param {Title} $title
@@ -219,6 +221,12 @@
$result = false;
}
+ $this->allowRetry = $result;
+
return $result;
}
+
+ function allowRetries() {
+ return $this->allowRetry;
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/226618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6eceb698f3856da97869a52826ccad94ad08973
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GWToolset
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
