Henning Snater has submitted this change and it was merged. Change subject: Fixed bug in wb.ui.Toolbar when adding same element multiple times ......................................................................
Fixed bug in wb.ui.Toolbar when adding same element multiple times Adding the same element multiple times is no longer possible. When adding an element already in the toolbar, it will be moved set to the given index. Also added a getLength() function and updated tests. Change-Id: Ia1912219c50b76310ff58267149f60a924e16787 --- M lib/resources/wikibase.ui.Toolbar.js M lib/tests/qunit/wikibase.ui.Toolbar.tests.js 2 files changed, 56 insertions(+), 0 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36590 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1912219c50b76310ff58267149f60a924e16787 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
