Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227182
Change subject: Fix: Creating an external link with no text selected results
link label as "null"
......................................................................
Fix: Creating an external link with no text selected results link label as
"null"
Testplan:
Without selecting any text, use link tool to add an external link. Once URL
entered, press enter. The link should be inserted at cursor position, with
label as link URL. Link label should not be null.
Bug: T106521
Change-Id: Ie904fb6f1b8b952a38eb7926d1d72c4cf428728e
---
M modules/tools/ext.cx.tools.link.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/82/227182/1
diff --git a/modules/tools/ext.cx.tools.link.js
b/modules/tools/ext.cx.tools.link.js
index edcaa43..2754565 100644
--- a/modules/tools/ext.cx.tools.link.js
+++ b/modules/tools/ext.cx.tools.link.js
@@ -1048,7 +1048,10 @@
self.$pageSelectorButton.prop( 'disabled', false );
} ).on( 'keypress', function ( e ) {
if ( e.which === 13 ) {
- self.createLink(
self.$targetPageSelector.getSelectedPage(), 'external' );
+ if ( linkType === 'external' ) {
+ self.createLink(
self.$externalLinkInput.val(), linkType );
+ }
+ // TODO: Add internal link also on enter
keypress.
}
} );
this.$internalLink.on( 'click', function () {
--
To view, visit https://gerrit.wikimedia.org/r/227182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie904fb6f1b8b952a38eb7926d1d72c4cf428728e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
