jenkins-bot has submitted this change and it was merged.
Change subject: Update Overlay test to be skin agnostic
......................................................................
Update Overlay test to be skin agnostic
the viewport is only in Minerva
Bug: T104362
Change-Id: I31358912890d17353d4e44fb57a57683fd19f0fd
---
M tests/qunit/mobile.overlays/test_Overlay.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/mobile.overlays/test_Overlay.js
b/tests/qunit/mobile.overlays/test_Overlay.js
index 8302076..0fac8bf 100644
--- a/tests/qunit/mobile.overlays/test_Overlay.js
+++ b/tests/qunit/mobile.overlays/test_Overlay.js
@@ -1,4 +1,4 @@
-( function ( M, $ ) {
+( function ( M ) {
var Overlay = M.require( 'Overlay' );
QUnit.module( 'MobileFrontend: Overlay.js', {
@@ -13,7 +13,7 @@
content: 'Text'
} );
overlay.show();
- assert.strictEqual( overlay.$el[ 0 ].parentNode, $(
'#mw-mf-viewport' )[ 0 ], 'In DOM' );
+ assert.ok( overlay.$el[ 0 ].parentNode !== undefined, 'In DOM'
);
overlay.hide();
} );
@@ -42,4 +42,4 @@
this.clock.tick( 1000 );
assert.strictEqual( overlay.$el[ 0 ].parentNode, null, 'No
longer in DOM' );
} );
-} )( mw.mobileFrontend, jQuery );
+} )( mw.mobileFrontend );
--
To view, visit https://gerrit.wikimedia.org/r/226437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31358912890d17353d4e44fb57a57683fd19f0fd
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: BarryTheBrowserTestBot <jdlrobson+ba...@gmail.com>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
