Victor Vasiliev has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227360
Change subject: Make wpReviewthis checkbox actually work
......................................................................
Make wpReviewthis checkbox actually work
WebRequest::getBool('fieldname', true) always returns true, because
it is impossible to distinguish between no form being submitted and form
being submitted with the checkbox unchecked.
This also has effect of making the checkbox in question unchecked by
default. This behavior is in fact desirable, because otherwise the
users could mark potentially bad changes as reviewed without realizing
that.
Change-Id: Ib57455d4275174dc46434b3ae02fdffefc5aaa35
---
M frontend/specialpages/actions/Stabilization_body.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/60/227360/1
diff --git a/frontend/specialpages/actions/Stabilization_body.php
b/frontend/specialpages/actions/Stabilization_body.php
index c6f20fa..390e6bf 100644
--- a/frontend/specialpages/actions/Stabilization_body.php
+++ b/frontend/specialpages/actions/Stabilization_body.php
@@ -45,7 +45,7 @@
# Watch checkbox
$form->setWatchThis( (bool)$request->getCheck( 'wpWatchthis' )
);
# Get auto-review option...
- $form->setReviewThis( $request->getBool( 'wpReviewthis', true )
);
+ $form->setReviewThis( $request->getCheck( 'wpReviewthis') );
# Reason
$form->setReasonExtra( $request->getText( 'wpReason' ) );
$form->setReasonSelection( $request->getVal(
'wpReasonSelection' ) );
--
To view, visit https://gerrit.wikimedia.org/r/227360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib57455d4275174dc46434b3ae02fdffefc5aaa35
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Victor Vasiliev <vasi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
