Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/227491
Change subject: Follow up to Ied1db3f, use lazyPush, remove unused imports, etc. ...................................................................... Follow up to Ied1db3f, use lazyPush, remove unused imports, etc. Change-Id: If209bbeb8871a3ac9e6c45b3258006a6b45bbad5 --- M client/includes/Hooks/DataUpdateHookHandlers.php M client/includes/Usage/EntityUsage.php 2 files changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/91/227491/1 diff --git a/client/includes/Hooks/DataUpdateHookHandlers.php b/client/includes/Hooks/DataUpdateHookHandlers.php index 42d9d78..27fb64c 100644 --- a/client/includes/Hooks/DataUpdateHookHandlers.php +++ b/client/includes/Hooks/DataUpdateHookHandlers.php @@ -4,7 +4,6 @@ use Content; use JobQueueGroup; -use JobSpecification; use LinksUpdate; use ManualLogEntry; use ParserCache; @@ -14,7 +13,6 @@ use User; use Wikibase\Client\Store\AddUsagesForPageJob; use Wikibase\Client\Store\UsageUpdater; -use Wikibase\Client\Usage\EntityUsage; use Wikibase\Client\Usage\ParserOutputUsageAccumulator; use Wikibase\Client\WikibaseClient; use WikiPage; @@ -162,7 +160,7 @@ * Implemented to update usage tracking information via UsageUpdater. * * @param ParserOutput $parserOutput - * @param $title $title + * @param Title $title */ public function doParserCacheSaveComplete( ParserOutput $parserOutput, Title $title ) { $usageAcc = new ParserOutputUsageAccumulator( $parserOutput ); @@ -186,7 +184,7 @@ //TODO: Before posting a job, check slave database. If no changes are needed, skip update. $addUsagesForPageJob = AddUsagesForPageJob::newSpec( $title, $usageAcc->getUsages(), $touched ); - $this->jobScheduler->push( $addUsagesForPageJob ); + $this->jobScheduler->lazyPush( $addUsagesForPageJob ); } /** diff --git a/client/includes/Usage/EntityUsage.php b/client/includes/Usage/EntityUsage.php index ba6938e..864efce 100644 --- a/client/includes/Usage/EntityUsage.php +++ b/client/includes/Usage/EntityUsage.php @@ -4,7 +4,6 @@ use InvalidArgumentException; use Wikibase\DataModel\Entity\EntityId; -use Wikibase\DataModel\Entity\EntityIdParsingException; /** * Value object representing the usage of an entity. This includes information about -- To view, visit https://gerrit.wikimedia.org/r/227491 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If209bbeb8871a3ac9e6c45b3258006a6b45bbad5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits