Jdlrobson has submitted this change and it was merged.

Change subject: jshint test suite
......................................................................


jshint test suite

* add a .jshintignore file - tell it to ignore external files and the fixtures
* cleanup the tests:
** remove MobileFrontendTests
** put required fixtures in the test modules themselves
** cleanup usage of MobileFrontendTests
** remove bogus test: "MobileFrontend application.js: logo click"
** improve styling as we go along
= jshint jenkins +1 ?
=> profit

Change-Id: I7e36d3cd2f0c36496a957e7944ce1263b5854388
---
A .jshintignore
M .jshintrc
M Makefile
M tests/js/fixtures.js
M tests/js/test_application.js
M tests/js/test_banner.js
M tests/js/test_references.js
M tests/js/test_settings.js
M tests/js/test_toggle.js
9 files changed, 44 insertions(+), 82 deletions(-)

Approvals:
  JGonera: Looks good to me, but someone else must approve
  Jdlrobson: Verified; Looks good to me, approved
  jenkins-bot: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.wikimedia.org/r/36919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e36d3cd2f0c36496a957e7944ce1263b5854388
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to