GWicke has uploaded a new change for review.
https://gerrit.wikimedia.org/r/229306
Change subject: Disable RESTBase config.yaml deploys in puppet
......................................................................
Disable RESTBase config.yaml deploys in puppet
RESTBase is completely driven by its Swagger spec based configuration. This
means that we need to thoroughly test new configurations in combination with
new code, and need to take all the same precautions for config deploys as for
code deploys.
Puppet's support for safe rolling deploys and selective test deploys is poor,
especially without merge rights on the ops puppet repository. As a result, our
config deploys are typically untested, and involve an elaborate manual
puppet-disable dance that is easy to get wrong.
As a step towards a longer-term solution, we have added a config.yaml template
in our regular Ansible deploy setup, and have started to use this for testing
in labs and staging. This has gone well, and has allowed us to safely improve
the configuration. Ansible's dry-run and diff functionality in particular has
been very helpful during development.
This patch disables config.yaml deploys in puppet, so that the RESTBase
configuration file can be fully controlled by the deploy system.
Bug: T107532
Change-Id: I433072988fe7fb912879563ae98bd8a60f8604af
---
M modules/restbase/manifests/init.pp
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/06/229306/1
diff --git a/modules/restbase/manifests/init.pp
b/modules/restbase/manifests/init.pp
index 933c086..a7f9b1b 100644
--- a/modules/restbase/manifests/init.pp
+++ b/modules/restbase/manifests/init.pp
@@ -105,12 +105,13 @@
before => Service['restbase'],
}
- file { '/etc/restbase/config.yaml':
- content => template($config_template),
- owner => 'root',
- group => 'root',
- mode => '0444',
- }
+ # Disabled in favor of Ansible
+ # file { '/etc/restbase/config.yaml':
+ # content => template($config_template),
+ # owner => 'root',
+ # group => 'root',
+ # mode => '0444',
+ # }
file { '/usr/lib/restbase':
ensure => directory,
--
To view, visit https://gerrit.wikimedia.org/r/229306
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I433072988fe7fb912879563ae98bd8a60f8604af
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: GWicke <gwi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
