jenkins-bot has submitted this change and it was merged.
Change subject: Never unconditionally 'return false' from interface hooks
......................................................................
Never unconditionally 'return false' from interface hooks
Reverts e9a1d54.
This was causing the VisualEditor "Edit" tab to be missing on
en.wikipedia.org in all pages. It worked fine on test.wikipedia.org
because EducationProgram is not installed there.
At run-time, JavaScript fixes this up (because VE supports live configuation
changes to counter-act static page caching when e.g. VE is enabled
in additional namespaces) and that code was covering this bug.
However due to code now loading asynchronously in VE, the fact
that this is added at run-time is now a lot more visible and causing
flashes.
Bug: T107980
Change-Id: I3105f285238ba6b10fdce22198c7dc5e2d13b588
---
M EducationProgram.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/EducationProgram.hooks.php b/EducationProgram.hooks.php
index 5bc503e..0ddff50 100755
--- a/EducationProgram.hooks.php
+++ b/EducationProgram.hooks.php
@@ -218,7 +218,7 @@
public static function onPageTabs( SkinTemplate &$sktemplate, array
&$links ) {
self::displayTabs( $sktemplate, $links, $sktemplate->getTitle()
);
- return false;
+ return true;
}
/**
@@ -256,7 +256,7 @@
}
}
- return false;
+ return true;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/229954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3105f285238ba6b10fdce22198c7dc5e2d13b588
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
