Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/229980
Change subject: Don't try to use broken XiphQT-as-HTML5 in Safari
......................................................................
Don't try to use broken XiphQT-as-HTML5 in Safari
XiphQT components perhaps once worked in <video> and <audio> in
Safari but they don't as of Safari 8 on OS X 10.10.
Removed weird workaround that detected a registered ogg plugin
and claimed to support ogg natively in <video> and <audio>,
which resulted in just a blank screen (and even took priority
over ogv.js).
With this fixed, Safari will select ogv.js as expected.
Bug: T108251
Change-Id: I046814576efe04168e2eb75c9083caeee7bbe648
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
1 file changed, 0 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/80/229980/1
diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
index 42edfcd..2d3c5e5 100644
--- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
+++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
@@ -266,10 +266,6 @@
dummyvid.canPlayType(
'audio/ogg; codecs="vorbis"' )
) {
this.mediaPlayers.addPlayer(
oggNativePlayer );
- // older versions of safari do not
support canPlayType,
- // but xiph qt registers mimetype via
quicktime plugin
- } else if ( this.supportedMimeType(
'video/ogg' ) ) {
- this.mediaPlayers.addPlayer(
oggNativePlayer );
}
// Test for opus
--
To view, visit https://gerrit.wikimedia.org/r/229980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I046814576efe04168e2eb75c9083caeee7bbe648
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
