jenkins-bot has submitted this change and it was merged. Change subject: Remove skipping of a test case on SQLite ......................................................................
Remove skipping of a test case on SQLite Needs https://gerrit.wikimedia.org/r/229613 in core. Change-Id: I969c3d64c09b49925a0afa0bf1c809eb2dffc0dd --- M lib/tests/phpunit/store/Sql/SiteLinkTableTest.php 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/lib/tests/phpunit/store/Sql/SiteLinkTableTest.php b/lib/tests/phpunit/store/Sql/SiteLinkTableTest.php index b04beac..9361e99 100644 --- a/lib/tests/phpunit/store/Sql/SiteLinkTableTest.php +++ b/lib/tests/phpunit/store/Sql/SiteLinkTableTest.php @@ -69,10 +69,6 @@ * @depends testSaveLinksOfItem */ public function testSaveLinksOfItem_duplicate() { - if ( wfGetDB( DB_MASTER )->getType() === 'sqlite' ) { - $this->markTestSkipped( "Duplicated tables don't have indexes on them in SQLite, thus we can't test uniqueness handling." ); - } - $item = new Item( new ItemId( 'Q2' ) ); $item->getSiteLinkList()->addNewSiteLink( 'enwiki', 'Beer' ); -- To view, visit https://gerrit.wikimedia.org/r/229615 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I969c3d64c09b49925a0afa0bf1c809eb2dffc0dd Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Hoo man <h...@online.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
