Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230107
Change subject: Fix phpdoc for hooks
......................................................................
Fix phpdoc for hooks
Change-Id: Ie55df605d721dfe67eded0145d630329d0ba2c06
---
M CodeMirror.hooks.php
1 file changed, 12 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror
refs/changes/07/230107/1
diff --git a/CodeMirror.hooks.php b/CodeMirror.hooks.php
index c787958..dcd6421 100644
--- a/CodeMirror.hooks.php
+++ b/CodeMirror.hooks.php
@@ -1,7 +1,7 @@
<?php
-
class CodeMirrorHooks {
+
/** @var null|array Cached version of global variables, if available,
otherwise null */
private static $globalVariableScript = null;
/** @var null|boolean Saves, if CodeMirror should be loaded on this
page or not */
@@ -14,7 +14,8 @@
*
* @see
https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderRegisterModules
*
- * @param ResourceLoader &$resourceLoader The ResourceLoader object
+ * @param ResourceLoader &$rl The ResourceLoader object
+ *
* @return bool Always true
*/
public static function onResourceLoaderRegisterModules( ResourceLoader
$rl ) {
@@ -145,7 +146,9 @@
*
* @see
https://www.mediawiki.org/wiki/Manual:Hooks/MakeGlobalVariablesScript
*
- * @param ResourceLoader &$resourceLoader The ResourceLoader object
+ * @param array $vars
+ * @param OutputPage $out
+ *
* @return bool Always true
*/
public static function onMakeGlobalVariablesScript( array &$vars,
OutputPage $out ) {
@@ -161,7 +164,9 @@
*
* @see https://www.mediawiki.org/wiki/Manual:Hooks/BeforePageDisplay
*
- * @param ResourceLoader &$resourceLoader The ResourceLoader object
+ * @param OutputPage $out
+ * @param Skin $skin
+ *
* @return bool Always true
*/
public static function onBeforePageDisplay( OutputPage &$out, Skin
&$skin ) {
@@ -175,7 +180,9 @@
*
* @see https://www.mediawiki.org/wiki/Manual:Hooks/GetPreferences
*
- * @param ResourceLoader &$resourceLoader The ResourceLoader object
+ * @param User $user
+ * @param array $defaultPreferences
+ *
* @return bool Always true
*/
public static function onGetPreferences( User $user,
&$defaultPreferences ) {
--
To view, visit https://gerrit.wikimedia.org/r/230107
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie55df605d721dfe67eded0145d630329d0ba2c06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
