BBlack has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/230553

Change subject: tlsproxy: multi_accept off
......................................................................

tlsproxy: multi_accept off

This setting and the commentary about SSL errors pre-date
ops/puppet repo git conversion and is questionable...

Change-Id: Ic27abcf5a5ce14ee38395089cbc5cb3598d0d1ff
---
M modules/tlsproxy/templates/nginx.conf.erb
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/53/230553/1

diff --git a/modules/tlsproxy/templates/nginx.conf.erb 
b/modules/tlsproxy/templates/nginx.conf.erb
index 2566907..6daf258 100644
--- a/modules/tlsproxy/templates/nginx.conf.erb
+++ b/modules/tlsproxy/templates/nginx.conf.erb
@@ -40,9 +40,7 @@
 
 events {
     worker_connections  <%= @nginx_worker_connections %>;
-    # Setting multi_accept makes it much less likely that
-    # the SSL server will throw SSL connection errors
-    multi_accept on;
+    multi_accept off; # accept 1 conn per epoll hit, basically
     accept_mutex off; # better latencies at high connection rates
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/230553
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic27abcf5a5ce14ee38395089cbc5cb3598d0d1ff
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to