XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/230559

Change subject: [FIX] replace: Add replacements to their container
......................................................................

[FIX] replace: Add replacements to their container

The replacements from the fixes have only been added to the over all
replacements, but not their respective container which have been always empty.

Change-Id: Ie72f3acc02afeab994c95f0fd811c666801c6dbd
---
M scripts/replace.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/59/230559/1

diff --git a/scripts/replace.py b/scripts/replace.py
index 61faf7b..9dacfb8 100755
--- a/scripts/replace.py
+++ b/scripts/replace.py
@@ -902,12 +902,14 @@
                 pywikibot.warning('The new string "{0}" contains formatting '
                                   'characters like U+200E'.format(
                     chars.replace_invisible(replacement[1])))
-            replacements.append(ReplacementListEntry(
+            replacement_set.append(ReplacementListEntry(
                 old=replacement[0],
                 new=replacement[1],
                 fix_set=replacement_set,
                 edit_summary=summary,
             ))
+        if replacement_set:
+            replacements.extend(replacement_set)
 
     # Set the regular expression flags
     flags = re.UNICODE

-- 
To view, visit https://gerrit.wikimedia.org/r/230559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie72f3acc02afeab994c95f0fd811c666801c6dbd
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to