Spage has submitted this change and it was merged. Change subject: Dep. injection (blech) and tests for SchemaModule ......................................................................
Dep. injection (blech) and tests for SchemaModule - Inject memcached and HTTP clients to SchemaModule, to facilitate testing using mocks. - Make sure the last modified time is always specified as UNIX timestamp (wfTimestampnow() returns TS_MEDIAWIKI). - Add unit tests! Change-Id: I8f532a924b6fcdd12b94b2c1f4be2d16a5026c54 --- M EventLogging.module.php A tests/SchemaModuleTest.php 2 files changed, 185 insertions(+), 15 deletions(-) Approvals: Ori.livneh: Looks good to me, approved Spage: Verified; Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37294 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f532a924b6fcdd12b94b2c1f4be2d16a5026c54 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
