Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/230756
Change subject: Change the id of source title so that its prefix is same as parsoid ids ...................................................................... Change the id of source title so that its prefix is same as parsoid ids Recently we moved to parsoid generated Ids and our id validations changed. But the id of source title did not change accordingly and it broke the connection between source and target title elements And then it caused breakage of dynamic alignment of titles In this patch we keep the id prefix as mw. Testplan: Start a translation, In the target title, type some text that is so long that it cause line break. Observe if the titles of source and translation aligns dynamically. Bug: T108524 Change-Id: I02a1af3f2b8d00cb54c099f4c91c335d736d69a0 --- M modules/source/ext.cx.source.js M modules/translation/ext.cx.translation.js 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/56/230756/1 diff --git a/modules/source/ext.cx.source.js b/modules/source/ext.cx.source.js index d7efeea..d0b7d8f 100644 --- a/modules/source/ext.cx.source.js +++ b/modules/source/ext.cx.source.js @@ -107,7 +107,7 @@ this.$title = $( '<h2>' ) .attr( { - id: 'cx-source-title' + id: 'mwcx-source-title' } ) .addClass( 'cx-column__title' ) .text( mw.cx.sourceTitle ); diff --git a/modules/translation/ext.cx.translation.js b/modules/translation/ext.cx.translation.js index 41e5247..fcc2c13 100644 --- a/modules/translation/ext.cx.translation.js +++ b/modules/translation/ext.cx.translation.js @@ -59,7 +59,7 @@ $heading = $( '<h2>' ) .attr( { - 'data-source': 'cx-source-title', + 'data-source': 'mwcx-source-title', contenteditable: true } ) .addClass( 'cx-column__title' ) -- To view, visit https://gerrit.wikimedia.org/r/230756 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I02a1af3f2b8d00cb54c099f4c91c335d736d69a0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits