Arlolra has uploaded a new change for review. https://gerrit.wikimedia.org/r/230823
Change subject: Newlines in html table are ok ...................................................................... Newlines in html table are ok * Looks like this was missed in review, though it was somewhat alluded to: https://gerrit.wikimedia.org/r/#/c/173834/16/lib/ext.core.AttributeExpander.js "maybe mention the !nltkokay here is only non-html tables"" Change-Id: I009bfd62ab5e0bf2daf2e27c97585e9b2ff1d706 --- M lib/ext.core.AttributeExpander.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid refs/changes/23/230823/1 diff --git a/lib/ext.core.AttributeExpander.js b/lib/ext.core.AttributeExpander.js index f7d3e72..434fafd 100644 --- a/lib/ext.core.AttributeExpander.js +++ b/lib/ext.core.AttributeExpander.js @@ -241,7 +241,7 @@ var newAttrs = null; var nlTkPos = -1; var dp, i, l; - var nlTkOkay = !token.isHTMLTag() && !Util.isTableTag(token); + var nlTkOkay = !(!token.isHTMLTag() && Util.isTableTag(token)); // Identify attributes that were generated in full or in part using templates for (i = 0, l = oldAttrs.length; i < l; i++) { -- To view, visit https://gerrit.wikimedia.org/r/230823 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I009bfd62ab5e0bf2daf2e27c97585e9b2ff1d706 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/parsoid Gerrit-Branch: master Gerrit-Owner: Arlolra <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
