Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/230965
Change subject: deployment servers: use role keyword for role ...................................................................... deployment servers: use role keyword for role Use the role keyword to include the role instead of a regular include because then we can use role-based lookup in hiera data and put stuff like admin groups in one central place in role/common/ Change-Id: Id6a9ccead34904e4ec6ad07f5c99df2f2e387383 --- M manifests/site.pp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/65/230965/1 diff --git a/manifests/site.pp b/manifests/site.pp index db124ec..5416181 100644 --- a/manifests/site.pp +++ b/manifests/site.pp @@ -1696,9 +1696,9 @@ # codfw deployment host (pending set up) node 'mira.codfw.wmnet' { + role deployment::server include standard include base::firewall - include role::deployment::server include role::labsdb::manager include role::releases::upload @@ -2341,8 +2341,8 @@ node 'tin.eqiad.wmnet' { + role deplyment::server include standard - include role::deployment::server include role::labsdb::manager interface::add_ip6_mapped { 'main': -- To view, visit https://gerrit.wikimedia.org/r/230965 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6a9ccead34904e4ec6ad07f5c99df2f2e387383 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits