Ottomata has submitted this change and it was merged.
Change subject: Change percentage in EventLogging validation alert
......................................................................
Change percentage in EventLogging validation alert
To avoid false positives for eventlogging_difference_raw_validated,
this change raises the number of data points over the threshold
needed to trigger the alert from 3/15 to 4/15.
It also adds the modifier 'absolute' to the alarm's metric,
to also raise alerts in the unlikely case the number of valid events
is significantly higher than the number of raw events.
Bug: T108339
Change-Id: I64b2091be24a3b2531586cf5ea2ba775ef668d1a
---
M modules/eventlogging/manifests/monitoring/graphite.pp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Ottomata: Looks good to me, approved
Joal: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/eventlogging/manifests/monitoring/graphite.pp
b/modules/eventlogging/manifests/monitoring/graphite.pp
index 644f9fc..657c8f0 100644
--- a/modules/eventlogging/manifests/monitoring/graphite.pp
+++ b/modules/eventlogging/manifests/monitoring/graphite.pp
@@ -45,10 +45,10 @@
# characteristic that is worth alerting on.
monitoring::graphite_threshold { 'eventlogging_difference_raw_validated':
description => 'Difference between raw and validated EventLogging
overall message rates',
- metric =>
'movingAverage(diffSeries(eventlogging.overall.raw.rate,eventlogging.overall.valid.rate),10)',
+ metric =>
'movingAverage(absolute(diffSeries(eventlogging.overall.raw.rate,eventlogging.overall.valid.rate)),10)',
warning => 20,
critical => 30,
- percentage => 15, # At least 3 of the 15 readings
+ percentage => 25, # At least 4 of the 15 readings
from => '15min',
contact_group => 'analytics',
}
--
To view, visit https://gerrit.wikimedia.org/r/230825
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64b2091be24a3b2531586cf5ea2ba775ef668d1a
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mforns <[email protected]>
Gerrit-Reviewer: Joal <[email protected]>
Gerrit-Reviewer: Madhuvishy <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
