jenkins-bot has submitted this change and it was merged.
Change subject: Always call setValidationHash() in MessageCache::saveToCaches()
......................................................................
Always call setValidationHash() in MessageCache::saveToCaches()
* This avoids constant churn when $wgUseLocalMessageCache is set to false
* Follow up to db464b8a847a
Bug: T109183
Change-Id: I8da324c53527da32d09964be6c3a92176af4ee7b
---
M includes/cache/MessageCache.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Ori.livneh: Looks good to me, approved
Nikerabbit: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php
index 3f60d8c..7945c8b 100644
--- a/includes/cache/MessageCache.php
+++ b/includes/cache/MessageCache.php
@@ -639,9 +639,10 @@
$success = true;
}
+ $this->setValidationHash( $code, $cache['HASH'] );
+
# Save to local cache
if ( $wgUseLocalMessageCache ) {
- $this->setValidationHash( $code, $cache['HASH'] );
$this->saveToLocalCache( $code, $cache );
}
--
To view, visit https://gerrit.wikimedia.org/r/231856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8da324c53527da32d09964be6c3a92176af4ee7b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
