Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232483

Change subject: Rebuild tree when toggling input debugging
......................................................................

Rebuild tree when toggling input debugging

So that debug markers (dis)appear instantly.

Change-Id: I896e49cf4572b6169438b921da213ca1820b1e95
---
M src/ui/ve.ui.DebugBar.js
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/83/232483/1

diff --git a/src/ui/ve.ui.DebugBar.js b/src/ui/ve.ui.DebugBar.js
index cc3d824..1fd8124 100644
--- a/src/ui/ve.ui.DebugBar.js
+++ b/src/ui/ve.ui.DebugBar.js
@@ -274,7 +274,17 @@
 };
 
 ve.ui.DebugBar.prototype.onInputDebuggingToggleClick = function () {
+       var surfaceModel = this.getSurface().getModel(),
+               selection = surfaceModel.getSelection();
+
        ve.inputDebug = this.inputDebuggingToggle.getValue();
+
+       // Clear the cursor before rebuilding, it will be restored later
+       surfaceModel.setNullSelection();
+       setTimeout( function () {
+               surfaceModel.getDocument().rebuildTree();
+               surfaceModel.setSelection( selection );
+       } );
 };
 
 /**

-- 
To view, visit https://gerrit.wikimedia.org/r/232483
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I896e49cf4572b6169438b921da213ca1820b1e95
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to