Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232647

Change subject: Re-disable 2-pass Theora encoding temporarily
......................................................................

Re-disable 2-pass Theora encoding temporarily

Partial revert of 4f920fea

It looks like we have a broken old version of ffmpeg2theora in production
still; recommend re-enabling this again after updating our ancient video
scalers to Trusty + updated ffmpeg2theora package.

Old upstream bug: https://bugs.launchpad.net/ffmpeg2theora/+bug/978832

I can't repro the failure on a local install with the newer deps.

Bug: T109608
Change-Id: I7a2a110d4721d8d8407afc6d83ab522da5f98160
---
M WebVideoTranscode/WebVideoTranscode.php
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/47/232647/1

diff --git a/WebVideoTranscode/WebVideoTranscode.php 
b/WebVideoTranscode/WebVideoTranscode.php
index 03481ac..e4d0255 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -81,7 +81,7 @@
                                'samplerate'                 => '44100',
                                'channels'                   => '2',
                                'noUpscaling'                => 'true',
-                               'twopass'                    => 'true',
+                               //'twopass'                    => 'true', // 
temporarily disabled for broken ffmpeg2theora
                                'optimize'                   => 'true',
                                'keyframeInterval'           => '128',
                                'bufDelay'                   => '256',
@@ -96,7 +96,7 @@
                                'samplerate'                 => '44100',
                                'channels'                   => '2',
                                'noUpscaling'                => 'true',
-                               'twopass'                    => 'true',
+                               //'twopass'                    => 'true', // 
temporarily disabled for broken ffmpeg2theora
                                'optimize'                   => 'true',
                                'keyframeInterval'           => '128',
                                'bufDelay'                   => '256',
@@ -111,7 +111,7 @@
                                'samplerate'                 => '44100',
                                'channels'                   => '2',
                                'noUpscaling'                => 'true',
-                               'twopass'                    => 'true',
+                               //'twopass'                    => 'true', // 
temporarily disabled for broken ffmpeg2theora
                                'optimize'                   => 'true',
                                'keyframeInterval'           => '128',
                                'bufDelay'                   => '256',
@@ -126,7 +126,7 @@
                                'samplerate'                 => '44100',
                                'channels'                   => '2',
                                'noUpscaling'                => 'true',
-                               'twopass'                    => 'true',
+                               //'twopass'                    => 'true', // 
temporarily disabled for broken ffmpeg2theora
                                'optimize'                   => 'true',
                                'keyframeInterval'           => '128',
                                'bufDelay'                   => '256',
@@ -140,7 +140,7 @@
                                'videoQuality'               => 6,
                                'audioQuality'               => 3,
                                'noUpscaling'                => 'true',
-                               'twopass'                    => 'true',
+                               //'twopass'                    => 'true', // 
temporarily disabled for broken ffmpeg2theora
                                'optimize'                   => 'true',
                                'keyframeInterval'           => '128',
                                'videoCodec'                 => 'theora',
@@ -153,7 +153,7 @@
                                'videoQuality'               => 6,
                                'audioQuality'               => 3,
                                'noUpscaling'                => 'true',
-                               'twopass'                    => 'true',
+                               //'twopass'                    => 'true', // 
temporarily disabled for broken ffmpeg2theora
                                'optimize'                   => 'true',
                                'keyframeInterval'           => '128',
                                'videoCodec'                 => 'theora',

-- 
To view, visit https://gerrit.wikimedia.org/r/232647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a2a110d4721d8d8407afc6d83ab522da5f98160
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to