Andrew Bogott has submitted this change and it was merged.

Change subject: Exclude yet more kernels that break nova-compute.
......................................................................


Exclude yet more kernels that break nova-compute.

Bug T99738

Change-Id: Ib4ac90101a31f6bf358b9a0774b8f71b5a041288
---
M modules/openstack/manifests/nova/compute.pp
1 file changed, 7 insertions(+), 11 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/openstack/manifests/nova/compute.pp 
b/modules/openstack/manifests/nova/compute.pp
index 6b0789d..4dff6e5 100644
--- a/modules/openstack/manifests/nova/compute.pp
+++ b/modules/openstack/manifests/nova/compute.pp
@@ -92,23 +92,19 @@
         require => Package['nova-common'],
     }
 
-    # Fail hard and loud if the kernel is not recent enough to have a
-    # fix for the KSM bug in Trusty and refuse to install nova-compute
-    # entirely.
-    #
-    # see: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1346917
-
+    # Check for buggy kernels.  There are a lot of them!
     if os_version('ubuntu >= trusty') and (versioncmp($::kernelrelease, 
'3.13.0-46') < 0) {
-
-        fail('nova-compute not installed on buggy kernels')
-
+        # see: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1346917
+        fail('nova-compute not installed on buggy kernels.  Old versions of 
3.13 have a KSM bug.')
+    } elsif $::kernelrelease =~ /^3\.13\..*/ {
+        fail('nova-compute not installed on buggy kernels.  On 3.13 series 
kernels, instance suspension causes complete system lockup.')
+    } elsif $::kernelrelease =~ /^3\.19\..*/ {
+        fail('nova-compute not installed on buggy kernels.  On 3.19 series 
kernels, instance clocks die after resuming from suspension.')
     } else {
-
         package { [ 'nova-compute', 'nova-compute-kvm' ]:
             ensure  => present,
             require => [Class['openstack::repo'], Package['qemu-system']],
         }
-
     }
 
     # Without qemu-system, apt will install qemu-kvm by default,

-- 
To view, visit https://gerrit.wikimedia.org/r/232524
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4ac90101a31f6bf358b9a0774b8f71b5a041288
Gerrit-PatchSet: 6
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <[email protected]>
Gerrit-Reviewer: Andrew Bogott <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to