jenkins-bot has submitted this change and it was merged.
Change subject: Fix tab order of buttons
......................................................................
Fix tab order of buttons
Default option (allow) should precede secondary option (cancel)
in DOM order. Use float:right to preserve the design (allow should
be to the right of cancel).
Looks a bit ugly but not tragic with JS off.
Bug: T64763
Change-Id: I783129fa0f824ef7fc81015454d2dcbd38f60da4
---
M frontend/modules/ext.MWOAuth.AuthorizeForm.css
M frontend/specialpages/SpecialMWOAuth.php
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
CSteipp: Looks good to me, approved
jenkins-bot: Verified
diff --git a/frontend/modules/ext.MWOAuth.AuthorizeForm.css
b/frontend/modules/ext.MWOAuth.AuthorizeForm.css
index 209854d..140780a 100644
--- a/frontend/modules/ext.MWOAuth.AuthorizeForm.css
+++ b/frontend/modules/ext.MWOAuth.AuthorizeForm.css
@@ -24,6 +24,7 @@
}
input.mw-mwoauth-authorize-button {
+ float: right;
margin-left: .7em;
margin-right: .7em;
margin-bottom: .5em;
diff --git a/frontend/specialpages/SpecialMWOAuth.php
b/frontend/specialpages/SpecialMWOAuth.php
index 1c503fc..42dcad3 100644
--- a/frontend/specialpages/SpecialMWOAuth.php
+++ b/frontend/specialpages/SpecialMWOAuth.php
@@ -383,12 +383,12 @@
$form->addHeaderText( $this->msg( 'mwoauth-form-legal'
)->text() );
$form->suppressDefaultSubmit();
- $form->addButton( 'cancel',
- wfMessage( 'mwoauth-form-button-cancel' )->text(), null,
- array( 'class' => 'mw-mwoauth-authorize-button
mw-ui-button mw-ui-quiet' ) );
$form->addButton( 'accept',
wfMessage( 'mwoauth-form-button-approve' )->text(),
null,
array( 'class' => 'mw-mwoauth-authorize-button
mw-ui-button mw-ui-constructive' ) );
+ $form->addButton( 'cancel',
+ wfMessage( 'mwoauth-form-button-cancel' )->text(), null,
+ array( 'class' => 'mw-mwoauth-authorize-button
mw-ui-button mw-ui-quiet' ) );
$form->addFooterText( $this->getSkin()->privacyLink() );
--
To view, visit https://gerrit.wikimedia.org/r/200753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I783129fa0f824ef7fc81015454d2dcbd38f60da4
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Jaredzimmerman <[email protected]>
Gerrit-Reviewer: Ricordisamoa <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
