Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/232864
Change subject: resourceloader: Remove remoteBasePath from FileModule version hash ...................................................................... resourceloader: Remove remoteBasePath from FileModule version hash In Wikimedia production this tends to contain the branch name, which causes the version to change for no reason after a MediaWiki deployment. For example: ["remoteBasePath"]=> string(43) "https://test.wikipedia.org/static/1.26wmf19"; Bug: T102578 Change-Id: I50b8afd72183cae875d4aaa0aaf0da4e7d664284 --- M includes/resourceloader/ResourceLoaderFileModule.php 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/64/232864/1 diff --git a/includes/resourceloader/ResourceLoaderFileModule.php b/includes/resourceloader/ResourceLoaderFileModule.php index efb151e..3224b13 100644 --- a/includes/resourceloader/ResourceLoaderFileModule.php +++ b/includes/resourceloader/ResourceLoaderFileModule.php @@ -591,9 +591,10 @@ $options = array(); foreach ( array( - // T104950: Do not include localBasePath! That path may vary over time and needlessly - // invalidate cache. If the path changes in a way that makes relative file paths point - // to something else, getFileHashes() will incorporate that already. + // T104950: Do not include localBasePath or remoteBasePath! + // Those paths may vary over time and needlessly invalidate cache. If the path changes + // in a way that makes relative file paths point to something else, getFileHashes() will + // account for that already. 'scripts', 'debugScripts', 'loaderScripts', @@ -608,7 +609,6 @@ 'group', 'position', 'skipFunction', - 'remoteBasePath', 'debugRaw', 'raw', ) as $member ) { -- To view, visit https://gerrit.wikimedia.org/r/232864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I50b8afd72183cae875d4aaa0aaf0da4e7d664284 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.26wmf19 Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
