jenkins-bot has submitted this change and it was merged.
Change subject: Use default Material button selector in a couple more places.
......................................................................
Use default Material button selector in a couple more places.
- License icon in Gallery.
- "x" button in Tab list.
- Buttons in the Disambig dialog.
Change-Id: Ied751e4564bd55d1f54db0a50ff1c0de7ff1858e
---
M app/src/main/res/layout/activity_gallery.xml
M app/src/main/res/layout/dialog_page_info.xml
M app/src/main/res/layout/item_tab_entry.xml
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
BearND: Looks good to me, approved
Niedzielski: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/app/src/main/res/layout/activity_gallery.xml
b/app/src/main/res/layout/activity_gallery.xml
index d87599a..b977886 100644
--- a/app/src/main/res/layout/activity_gallery.xml
+++ b/app/src/main/res/layout/activity_gallery.xml
@@ -66,7 +66,7 @@
android:layout_width="24dp"
android:layout_height="24dp"
android:padding="5dp"
- android:background="@drawable/selectable_item_background"
+ android:background="?attr/selectableItemBackgroundBorderless"
tools:src="@drawable/ic_license_cc"
android:contentDescription="@null"/>
<TextView
diff --git a/app/src/main/res/layout/dialog_page_info.xml
b/app/src/main/res/layout/dialog_page_info.xml
index 545b5a5..ad40c32 100644
--- a/app/src/main/res/layout/dialog_page_info.xml
+++ b/app/src/main/res/layout/dialog_page_info.xml
@@ -28,7 +28,7 @@
android:paddingLeft="16dp"
android:paddingRight="16dp"
style="@style/TextHeadingGray"
- android:background="@drawable/button_selector_transparent"
+ android:background="?attr/selectableItemBackground"
android:text="@string/page_similar_titles" />
<TextView
@@ -52,7 +52,7 @@
android:paddingLeft="16dp"
android:paddingRight="16dp"
style="@style/TextHeadingGray"
- android:background="@drawable/button_selector_transparent"
+ android:background="?attr/selectableItemBackground"
android:text="@string/dialog_page_issues" />
<View
@@ -70,7 +70,7 @@
android:layout_gravity="center_vertical"
android:gravity="center"
android:src="@drawable/ic_close_gray"
- android:background="@drawable/button_selector_transparent"
+ android:background="?attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/dialog_close_description" />
</LinearLayout>
diff --git a/app/src/main/res/layout/item_tab_entry.xml
b/app/src/main/res/layout/item_tab_entry.xml
index c172352..c7ed131 100644
--- a/app/src/main/res/layout/item_tab_entry.xml
+++ b/app/src/main/res/layout/item_tab_entry.xml
@@ -46,7 +46,7 @@
android:src="@drawable/ic_close_gray"
android:contentDescription="@string/button_close_tab"
android:clickable="true"
- android:background="@drawable/button_selector_transparent"
+ android:background="?attr/selectableItemBackgroundBorderless"
/>
</LinearLayout>
<View
--
To view, visit https://gerrit.wikimedia.org/r/232431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied751e4564bd55d1f54db0a50ff1c0de7ff1858e
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
