Tim Landscheidt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/232867

Change subject: base: Don't install command-not-found-data either
......................................................................

base: Don't install command-not-found-data either

Change I789644c8da4ff374918e9ff98238bb13c237ddfc removed the package
command-not-found with the intention of lower command line latency.
But now the error message is the rather obscure:

| scfc@toolsbeta-puppetmaster3:~$ does-not-exist
| /usr/bin/python: can't find '__main__' module in 
'/usr/share/command-not-found'
| scfc@toolsbeta-puppetmaster3:~$

This change removes the package command-not-found-data as well,
yielding the wanted:

| scfc@toolsbeta-puppetmaster3:~$ does-not-exist
| -bash: does-not-exist: command not found
| scfc@toolsbeta-puppetmaster3:~$

For login sessions that are active when the package is removed, the
results are temporarily bizarre:

| scfc@toolsbeta-puppetmaster3:~$ does-not-exist
| scfc@toolsbeta-puppetmaster3:~$

But given that this will stop as soon as the user logs out, this
change doesn't attempt to fix this in favour of simplicity.

Change-Id: Id9af35d8e33aea13d329bf5511d85ef7c578b87f
---
M modules/base/manifests/standard-packages.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/67/232867/1

diff --git a/modules/base/manifests/standard-packages.pp 
b/modules/base/manifests/standard-packages.pp
index 633a19e9..af7710e 100644
--- a/modules/base/manifests/standard-packages.pp
+++ b/modules/base/manifests/standard-packages.pp
@@ -6,7 +6,7 @@
         }
     }
 
-    package { 'command-not-found':
+    package { ['command-not-found', 'command-not-found-data']:
         ensure => absent,
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/232867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9af35d8e33aea13d329bf5511d85ef7c578b87f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to