BBlack has uploaded a new change for review.
https://gerrit.wikimedia.org/r/232945
Change subject: mobile vcl: tighten up disableImages cookie regex
......................................................................
mobile vcl: tighten up disableImages cookie regex
Bug: T109286
Change-Id: I79ecfdb039c3c9c85154bd5ba3bc440513a05cd0
---
M templates/varnish/text-common.inc.vcl.erb
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/45/232945/1
diff --git a/templates/varnish/text-common.inc.vcl.erb
b/templates/varnish/text-common.inc.vcl.erb
index 1a5048e..9ee058a 100644
--- a/templates/varnish/text-common.inc.vcl.erb
+++ b/templates/varnish/text-common.inc.vcl.erb
@@ -35,9 +35,11 @@
// most of this mechanism but have a different Cookie regex during
// the refactoring process...
sub evaluate_cookie_mobile {
- // note extra matches for any Cookie-string that matches /disable/
(needs further investigation!)
- // and for 'optin=foo' (used for alpha/beta opt-in)
- if (req.http.Cookie ~ "disable|((^|;\s*)optin|[sS]ession|Token)="
+ // note extra matches for disableImages= and for optin=foo, which
+ // create unique and valid variances for alpha-vs-beta-vs-stable, and
+ // for images-vs-not. optin has no prefix, so we can be more-precise,
+ // whereas disableImages has a wikiname prefix like session/token do.
+ if (req.http.Cookie ~ "((^|;\s*)optin|disableImages|[sS]ession|Token)="
&& req.url !~ "^/static/"
&& req.url !~ "^/w/load\.php") {
set req.hash_ignore_busy = true;
--
To view, visit https://gerrit.wikimedia.org/r/232945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79ecfdb039c3c9c85154bd5ba3bc440513a05cd0
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
