jenkins-bot has submitted this change and it was merged.
Change subject: Put back notification_timestamp for web.
......................................................................
Put back notification_timestamp for web.
Although it wasn't here even before
c94c3f3dad668bd697652a6aa303430d3db6ddff , loadFromRow will make
use if it if it's present. Otherwise, it's the current timestamp
(which seems odd; if we really don't need the timestamp in a
particular scenario, null would be more straightforward).
This is also public (getTimestamp()).
Change-Id: I9d88d86dde5b7f9b5965c81225a2aab4354c2baa
---
M includes/mapper/EventMapper.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alex Monk: Looks good to me, but someone else must approve
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/mapper/EventMapper.php b/includes/mapper/EventMapper.php
index 69db509..e60999a 100644
--- a/includes/mapper/EventMapper.php
+++ b/includes/mapper/EventMapper.php
@@ -79,7 +79,8 @@
$res = $dbr->select(
array( 'echo_notification', 'echo_event' ),
array( 'event_agent_id', 'event_agent_ip',
'event_extra',
- 'event_id', 'event_page_id',
'event_type', 'event_variant' ),
+ 'event_id', 'event_page_id',
'event_type', 'event_variant',
+ 'notification_timestamp' ),
array(
'notification_event=event_id',
'notification_user' => $user->getId(),
--
To view, visit https://gerrit.wikimedia.org/r/234126
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d88d86dde5b7f9b5965c81225a2aab4354c2baa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
