jenkins-bot has submitted this change and it was merged.
Change subject: Use Firefox for browser @integration tests
......................................................................
Use Firefox for browser @integration tests
Chrome has problems with window resizing which can lead to false
positives (see T109593). Given we have some important tests such as not showing
table of contents on mobile, toggling let's switch
Change-Id: Ic844661ebd2df333c5e6ac2de21857d08f02798a
---
M tests/browser/environments.yml
M tests/browser/features/toggling.feature
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Dduvall: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/environments.yml b/tests/browser/environments.yml
index b6e4d95..d36f01a 100644
--- a/tests/browser/environments.yml
+++ b/tests/browser/environments.yml
@@ -38,7 +38,7 @@
# mediawiki_password: SET THIS IN THE ENVIRONMENT!
integration:
- browser: chrome
+ browser: firefox
user_factory: true
# mediawiki_url: JENKINS WILL SET THIS
diff --git a/tests/browser/features/toggling.feature
b/tests/browser/features/toggling.feature
index 0495392..0ffc2a3 100644
--- a/tests/browser/features/toggling.feature
+++ b/tests/browser/features/toggling.feature
@@ -9,7 +9,7 @@
When I visit the page "Selenium section test page" with hash "#Section_2A"
Then the heading element with id "Section_2A" should be visible
- @smoke @FIXME:T109593
+ @smoke @integration
Scenario: Opening a section on mobile
Given I go to a page that has sections
When I click on the first collapsible section heading
--
To view, visit https://gerrit.wikimedia.org/r/234394
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic844661ebd2df333c5e6ac2de21857d08f02798a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
