jenkins-bot has submitted this change and it was merged.
Change subject: VisualEditorWidget: Guard against setting selection to -1
......................................................................
VisualEditorWidget: Guard against setting selection to -1
Bug: T110393
Change-Id: I5d65c2eba3f819bb9aa32cf62a678c0756b2591a
---
M modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js
b/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js
index fe25ed6..0e28cfa 100644
--- a/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js
+++ b/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js
@@ -146,7 +146,9 @@
var data = this.target.surface.getModel().getDocument().data,
cursorPos = data.getNearestContentOffset(
data.getLength(), -1 );
- this.target.surface.getModel().setLinearSelection( new
ve.Range( cursorPos ) );
+ if ( cursorPos !== -1 ) {
+ this.target.surface.getModel().setLinearSelection( new
ve.Range( cursorPos ) );
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/234343
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d65c2eba3f819bb9aa32cf62a678c0756b2591a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
